expression: modify the test framework for vectorized expression evaluation functions #12115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reminiscent
requested review from
SunRunAway,
zz-jason,
qw4990,
XuHuaiyu and
wshwsh12
|
|
SunRunAway
reviewed
Sep 10, 2019
expression/bench_test.go
Outdated
| @@ -385,9 +369,9 @@ func genVecExprBenchCase(ctx sessionctx.Context, funcName string, testCase vecEx | |||
| return expr, input, output | |||
| } | |||
|
|
|||
| func (s *testEvaluatorSuite) TestVectorizedEvalOneVec(c *C) { | |||
| func (s *testEvaluatorSuite) testVectorizedEvalOneVec(c *C, vecExprCases vecExprBenchCases) { | |||
There was a problem hiding this comment.
How about adding some comments for contributors with those four functions/methods.
Codecov Report
@@ Coverage Diff @@
## master #12115 +/- ##
===========================================
Coverage 81.4145% 81.4145%
===========================================
Files 450 450
Lines 96947 96947
===========================================
Hits 78929 78929
Misses 12391 12391
Partials 5627 5627 |
qw4990
reviewed
Sep 10, 2019
XuHuaiyu
changed the title
qw4990
added
status/can-merge
|
/run-all-tests |
qw4990
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Modify the test framework for vectorized expression evaluation functions.
What is changed and how it works?
Create a test file for each different kind of vectorized expression. Add corresponding cases to each individual test file. Pass the corresponding cases to the unit test and benchmark functions in bench_test.go in each test file. It can effectively reduce conflicts.
Check List
Tests