types: fix a bug of FromGoTime when handling rounding
#12240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FromGoTime("2019-09-11 11:17:47.999999666") should round to
{2019 9 11 11 17 48 0}
But get
{2019 9 11 11 17 47 1000000}
tiancaiamao
added
type/bugfix
|
PTAL @crazycs520 @jackysp @lysu |
Codecov Report
@@ Coverage Diff @@
## master #12240 +/- ##
===========================================
Coverage 81.2985% 81.2985%
===========================================
Files 454 454
Lines 100008 100008
===========================================
Hits 81305 81305
Misses 12873 12873
Partials 5830 5830 |
lysu
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
|
cherry pick to release-3.1 failed |
|
cherry pick to release-2.1 failed |
jacklightChen
added a commit
to jacklightChen/tidb
that referenced
this pull request
Sep 18, 2019
types: fix a bug of `FromGoTime` when handling rounding (pingcap#12240)
This was referenced Sep 18, 2019
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1 release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @tiancaiamao PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #12163
FromGoTime("2019-09-11 11:17:47.999999666") should be round to
But the old code get
That cause the bug in issues/12163
What is changed and how it works?
Fix the
FromGoTimefunctionCheck List
Tests
Related changes
Release note