planner: tiny code refine for contructIndexJoin #12254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code_4_indexjoin
|
/run-all-tests |
3 tasks
…code_4_indexjoin
Codecov Report
@@ Coverage Diff @@
## master #12254 +/- ##
=========================================
Coverage 81.191% 81.191%
=========================================
Files 454 454
Lines 99176 99176
=========================================
Hits 80522 80522
Misses 12883 12883
Partials 5771 5771 |
eurekaka
reviewed
Sep 18, 2019
| return rightJoins, true | ||
| } | ||
|
|
||
| if leftJoins != nil && lhsCardinality < rhsCardinality { |
There was a problem hiding this comment.
We should remove this heuristic rule actually? Previously, cost of index join computed only depends on row count of outer child, then this rule can hold, but now we have changed the cost computation of index join to consider inner row count as well, so it would not always be better if outer row count is smaller?
There was a problem hiding this comment.
Should we make this change in an individual PR?
This PR only refines the code structure.
lzmhhh123
added
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Tiny code refine for contructIndexJoin
What is changed and how it works?
Extract 2 functions:
buildIndexJoinInner2TableScan
buildIndexJoinInner2IndexScan
Check List
Tests
Exists tests.
Code changes
N/A
Side effects
N/A
Related changes
N/A
Release note
N/A