executor: refactoring the 'replace' implementation, remove its dependency of batch checker #12319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ency of batch checker
tiancaiamao
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #12319 +/- ##
===========================================
Coverage 81.1011% 81.1011%
===========================================
Files 454 454
Lines 99329 99329
===========================================
Hits 80557 80557
Misses 12960 12960
Partials 5812 5812 |
tiancaiamao
requested review from
lysu and
jackysp
and removed request for
lysu
lysu
added
status/LGT2
|
Your auto merge job has been accepted, waiting for 12307 |
|
/run-all-tests |
|
cherry pick to release-3.1 failed |
|
cherry pick to release-3.0 failed |
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Nov 19, 2019
…ency of batch checker (pingcap#12319)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Code refactor.
Batch check should be removed, as I've said in #12108
What is changed and how it works?
Don't use batch checker in 'replace'
Check List
Tests
Related changes
Release note