Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add index speed metric #12374

Merged
merged 5 commits into from
Sep 25, 2019
Merged

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Sep 25, 2019

What problem does this PR solve?

Add a metric for DDL add index speed.
Related PR: pingcap/tidb-ansible#976

image

What is changed and how it works?

Check List

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Add a metric for DDL add index speed.

@codecov
Copy link

codecov bot commented Sep 25, 2019

Codecov Report

Merging #12374 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12374   +/-   ##
===========================================
  Coverage   80.7571%   80.7571%           
===========================================
  Files           454        454           
  Lines         99533      99533           
===========================================
  Hits          80380      80380           
  Misses        13356      13356           
  Partials       5797       5797

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

metrics/ddl.go Show resolved Hide resolved
ddl/index.go Show resolved Hide resolved
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 changed the title ddl: add index speed metric metrics: add index speed metric Sep 25, 2019
@bb7133 bb7133 added component/metrics status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. needs-cherry-pick-2.1 and removed component/DDL-need-LGT3 labels Sep 25, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

@crazycs520 merge failed.

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 merged commit 4891e18 into pingcap:master Sep 25, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

cherry pick to release-2.1 in PR #12389

@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

cherry pick to release-3.0 in PR #12390

@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

cherry pick to release-3.1 in PR #12391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants