Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for 'builtinCastStringAsJSONSig' #12802

Merged
merged 4 commits into from
Oct 18, 2019
Merged

expression: implement vectorized evaluation for 'builtinCastStringAsJSONSig' #12802

merged 4 commits into from
Oct 18, 2019

Conversation

tsthght
Copy link
Contributor

@tsthght tsthght commented Oct 17, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinCastStringAsJSONSig, for #12104

What is changed and how it works?

BenchmarkVectorizedBuiltinCastFunc/builtinCastStringAsJSONSig-VecBuiltinFunc-8         	    1000	   1899624 ns/op	 1605641 B/op	   17408 allocs/op
BenchmarkVectorizedBuiltinCastFunc/builtinCastStringAsJSONSig-NonVecBuiltinFunc-8      	    1000	   1945476 ns/op	 1605639 B/op	   17408 allocs/op

Check List

Tests

  • Unit test

@tsthght tsthght requested a review from a team as a code owner October 17, 2019 12:50
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 17, 2019
@ghost ghost requested review from wshwsh12 and removed request for a team October 17, 2019 12:50
@zyxbest
Copy link
Contributor

zyxbest commented Oct 17, 2019

/build

@codecov
Copy link

codecov bot commented Oct 17, 2019 •
edited
Loading

Codecov Report

Merging #12802 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12802   +/-   ##
===========================================
  Coverage   80.0043%   80.0043%           
===========================================
  Files           465        465           
  Lines        106533     106533           
===========================================
  Hits          85231      85231           
  Misses        14946      14946           
  Partials       6356       6356

wshwsh12
wshwsh12 reviewed Oct 18, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SunRunAway
SunRunAway reviewed Oct 18, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Oct 18, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2019

Your auto merge job has been accepted, waiting for 12800

@sre-bot
Copy link
Contributor

sre-bot commented Oct 18, 2019

/run-all-tests

@sre-bot sre-bot merged commit 286047b into pingcap:master Oct 18, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@tsthght @XiaTianliang
expression: implement vectorized evaluation for 'builtinCastStringAsJ…
f71bfbb 
…SONSig' (pingcap#12802)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tsthght @zyxbest @sre-bot @SunRunAway @wshwsh12