infoschema: add information_schema.tidb_cluster_info to retrieve cluster topology. #13035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter topology. Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Codecov Report
@@ Coverage Diff @@
## master #13035 +/- ##
================================================
- Coverage 80.2271% 80.0246% -0.2025%
================================================
Files 468 468
Lines 111208 110146 -1062
================================================
- Hits 89219 88144 -1075
- Misses 15212 15217 +5
- Partials 6777 6785 +8 |
zimulala
reviewed
Nov 1, 2019
djshow832
reviewed
Nov 1, 2019
djshow832
reviewed
Nov 1, 2019
| if err != nil { | ||
| return nil, errors.Trace(err) | ||
| } | ||
| terror.Log(resp.Body.Close()) |
There was a problem hiding this comment.
In this way, it always calls an extra function.
There was a problem hiding this comment.
terror.Log it a utility function equals if err != nil {...}.
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
|
LGTM |
crazycs520
reviewed
Nov 4, 2019
infoschema/tables.go
Outdated
|
|
||
| // Get PD git_hash | ||
| url = fmt.Sprintf("http://%s%s", addr, pdapi.Status) | ||
| resp, err = http.Get(url) |
There was a problem hiding this comment.
The request will always handle by PD leader, should also change PD?
There was a problem hiding this comment.
Nice catch, seems PD should not redirect all request to leader.
Signed-off-by: Lonng <heng@lonng.org>
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
lonng
added
status/LGT2
56 tasks
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
In the current version, we don't have a simple way to get cluster information. We need to use different interfaces of different components or even different ways to get topology information.
What is changed and how it works?
This PR introduces the
information_schema.tidb_cluster_infoand make the user can retrieve cluster topology easier viaselect * from information_schema.tidb_cluster_info.Check List
Tests
Release note
select * from information_schema.tidb_cluster_info