Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: add builtin function json_valid (#12596) #13133

Merged
merged 5 commits into from
Nov 5, 2019
Merged

expression: add builtin function json_valid (#12596) #13133

merged 5 commits into from
Nov 5, 2019

Conversation

Reminiscent
Copy link
Contributor

@Reminiscent Reminiscent commented Nov 5, 2019 •
edited
Loading

cherry-pick #12596 to release-3.0

What problem does this PR solve?

Add json_valid builtin function described #7546.

What is changed and how it works?

See here for details.

@wjhuang2016 wjhuang2016 changed the title 3.0 json valid expression: add builtin function json_valid (#12596) Nov 5, 2019
@Reminiscent Reminiscent changed the title expression: add builtin function json_valid (#12596) expression: add builtin function json_valid Nov 5, 2019
SunRunAway
SunRunAway reviewed Nov 5, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2019
XuHuaiyu
XuHuaiyu approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 5, 2019
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Nov 5, 2019

/run-all-tests

@qw4990 qw4990 removed their request for review November 5, 2019 05:01
@SunRunAway
Copy link
Contributor

/run-all-tests

@eurekaka eurekaka added the status/can-merge Indicates a PR has been approved by a committer. label Nov 5, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 5, 2019

/run-all-tests

@sre-bot sre-bot merged commit 16a0358 into pingcap:release-3.0 Nov 5, 2019
@Reminiscent Reminiscent deleted the 3.0JsonValid branch December 24, 2019 12:16
@Reminiscent Reminiscent changed the title expression: add builtin function json_valid expression: add builtin function json_valid (#12596) Apr 9, 2020
@Reminiscent Reminiscent mentioned this pull request Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Reminiscent @XuHuaiyu @SunRunAway @sre-bot @eurekaka