Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinJSONKeys2ArgsSig #13262

Merged
merged 5 commits into from
Nov 11, 2019
Merged

expression: implement vectorized evaluation for builtinJSONKeys2ArgsSig #13262

merged 5 commits into from
Nov 11, 2019

Conversation

js00070
Copy link
Contributor

@js00070 js00070 commented Nov 7, 2019

PCP #12104

What problem does this PR solve?

implement vectorized evaluation for builtinJSONKeys2ArgsSig from #12104

What is changed and how it works?

about 3% faster

BenchmarkVectorizedBuiltinJSONFunc/builtinJSONKeys2ArgsSig-VecBuiltinFunc-12                2036            549221 ns/op          314230 B/op       2515 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONKeys2ArgsSig-NonVecBuiltinFunc-12             2073            565567 ns/op          314954 B/op       2515 allocs/op

Check List

Tests

  • Unit test

@js00070 js00070 requested a review from a team as a code owner November 7, 2019 12:46
@sre-bot
Copy link
Contributor

sre-bot commented Nov 7, 2019

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 7, 2019
@ghost ghost requested review from wshwsh12 and XuHuaiyu and removed request for a team November 7, 2019 12:46
@codecov
Copy link

codecov bot commented Nov 8, 2019 •
edited
Loading

Codecov Report

Merging #13262 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13262   +/-   ##
===========================================
  Coverage   80.1775%   80.1775%           
===========================================
  Files           469        469           
  Lines        112191     112191           
===========================================
  Hits          89952      89952           
  Misses        15285      15285           
  Partials       6954       6954

XuHuaiyu
XuHuaiyu reviewed Nov 11, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 11, 2019
qw4990
qw4990 approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

Your auto merge job has been accepted, waiting for 13194

@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

/run-all-tests

@sre-bot sre-bot merged commit 4aa3608 into pingcap:master Nov 11, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 11, 2019

@js00070 complete task #12104 and get 50 score, currerent score 150.

XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@js00070 @XiaTianliang
expression: implement vectorized evaluation for `builtinJSONKeys2Args…
b7b1745 
…Sig` (pingcap#13262)
@js00070 js00070 deleted the JSONKeys2Args branch February 1, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@qw4990 qw4990 qw4990 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@js00070 @sre-bot @qw4990 @XuHuaiyu @wshwsh12