infoschema: place INFORMATION_SCHEMA in new virtual table framework #13696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 tasks
Codecov Report
@@ Coverage Diff @@
## master #13696 +/- ##
===========================================
Coverage 79.9919% 79.9919%
===========================================
Files 473 473
Lines 116373 116373
===========================================
Hits 93089 93089
Misses 15938 15938
Partials 7346 7346 |
Signed-off-by: Lonng <heng@lonng.org>
bb7133
reviewed
Nov 22, 2019
Signed-off-by: Lonng <heng@lonng.org>
|
/run-all-tests |
ngaut
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
Fix issue #13694
The
informaction_schemashould be placed in the new virtual table framework. See:tidb/infoschema/builder.go
Line 326 in 71e19a7
What is changed and how it works?
Refactor it.
Check List
Tests
Release note