infoschema,planner: implement the CLUSTER_LOG memory table predicate push down #14018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lonng <heng@lonng.org>
ghost
requested review from
alivxxx and
winoros
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #14018 +/- ##
===========================================
Coverage 80.2791% 80.2791%
===========================================
Files 483 483
Lines 122353 122353
===========================================
Hits 98224 98224
Misses 16366 16366
Partials 7763 7763 |
56 tasks
Signed-off-by: Lonng <heng@lonng.org>
djshow832
reviewed
Dec 11, 2019
Co-Authored-By: djshow832 <873581766@qq.com>
Signed-off-by: Lonng <heng@lonng.org>
djshow832
reviewed
Dec 11, 2019
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
Signed-off-by: Lonng <heng@lonng.org>
1 task
crazycs520
reviewed
Dec 13, 2019
crazycs520
reviewed
Dec 13, 2019
winoros
reviewed
Dec 13, 2019
|
|
||
| // extracts the time range column, e.g: | ||
| // SELECT * FROM t WHERE time='2019-10-10 10:10:10' | ||
| // SELECT * FROM t WHERE time>'2019-10-10 10:10:10' AND time<'2019-10-11 10:10:10' |
There was a problem hiding this comment.
So you don't deal with (time > ... and time < ...) or (time > ... and time < ...)?
There was a problem hiding this comment.
Yes, to simplify the implementation of the diagnostics service search log interface, it can just accept only one range of time (pick a group of the log files in the time range). So the filtering will be executed in TiDB via Selection executor.
There was a problem hiding this comment.
Generally, we use the cluster level log search function to locate the problem usually only one range of time. So I think it's enough to cover this scenario.
Signed-off-by: Lonng <heng@lonng.org>
…uster-log-push-down
Signed-off-by: Lonng <heng@lonng.org>
|
Please modify the PR title: infoschema, planner: xxx |
lonng
changed the title
lonng
changed the title
|
@djshow832 Done |
crazycs520
approved these changes
Dec 16, 2019
crazycs520
added
the
status/can-merge
|
/run-all-tests |
|
@lonng merge failed. |
|
/run-unit-test |
lonng
added
sig/planner
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
…push down (pingcap#14018) Signed-off-by: Lonng <heng@lonng.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng heng@lonng.org
What problem does this PR solve?
This PR implement the predicate push-down part of the
CLUSTER_LOGmemory table.It's a subtask of issue #13567
What is changed and how it works?
CLUSTER_LOGmemory table.ClusterLogTableExtractorNOTE: The
CLUSTER_LOGmemory table implementation will be split into two PRs to make it reviewable. The retriever will be implemented in the next PR.Check List
Tests
Release note