expression, executor: correct the funcName for wrapWithIsTrue #14515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
added
type/bugfix
ghost
requested review from
qw4990 and
SunRunAway
and removed request for
a team
|
/run-all-tests |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@XuHuaiyu merge failed. |
|
/rebuild |
|
/merge |
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #14516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #14514
What is changed and how it works?
Correct the name of function IsTrue in wrapWithIsTrue.
In SimplifyOuterJoin, all the columns will be replaced by
null, and the function will be reconstructed. The invalid function name before this commit will cause a panic.Check List
Tests
Code changes
Side effects
N/A
Related changes
Release note