infoschema: add metrics_summary_by_label table to query all detail metrics #14663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs <crazycs520@gmail.com>
ghost
requested review from
eurekaka and
francis0407
and removed request for
a team
crazycs520
commented
Feb 6, 2020
| @@ -853,6 +853,10 @@ func createSessionFunc(store kv.Storage) pools.Factory { | |||
| if err != nil { | |||
| return nil, errors.Trace(err) | |||
| } | |||
| err = variable.SetSessionSystemVar(se.sessionVars, variable.MaxAllowedPacket, types.NewStringDatum("67108864")) | |||
There was a problem hiding this comment.
In PR #11137, concat_ws will need this variable, so I set this variable here for internal sql.
Signed-off-by: crazycs <crazycs520@gmail.com>
crazycs520
changed the title
lonng
reviewed
Feb 9, 2020
lonng
reviewed
Feb 9, 2020
lonng
reviewed
Feb 9, 2020
Signed-off-by: crazycs <crazycs520@gmail.com>
|
/run-all-tests |
lonng
reviewed
Feb 10, 2020
executor/metric_reader.go
Outdated
| startTime := e.extractor.StartTime.Format(plannercore.MetricTableTimeFormat) | ||
| endTime := e.extractor.EndTime.Format(plannercore.MetricTableTimeFormat) | ||
| for name, def := range infoschema.MetricTableMap { | ||
| sqls := e.genMetricQuerySQLS(name, startTime, endTime, def.Quantile, quantiles, def) |
There was a problem hiding this comment.
The e.genMetricQuerySQLS method accepts the def, so I think the def.Quantile is unnecessary.
lonng
reviewed
Feb 10, 2020
Signed-off-by: crazycs <crazycs520@gmail.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazycs crazycs520@gmail.com
What problem does this PR solve?
Add the
metrics_summary_by_labeltable to query all detail metrics. It is the tablemetrics_summaryby label.This table can quickly help Users to find abnormal metrics in detail between two different times.
eg:
-- compare 2 different time range metrics and order by ratio.
What is changed and how it works?
Check List
Tests