planner: consider disk cost in Sort #14708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
removed their request for review
lzmhhh123
reviewed
Feb 12, 2020
planner/core/task.go
Outdated
| @@ -841,19 +841,45 @@ func (p *PhysicalTopN) allColsFromSchema(schema *expression.Schema) bool { | |||
| return len(schema.ColumnsIndices(cols)) > 0 | |||
| } | |||
|
|
|||
| func (p *PhysicalSort) avgRowSize(schema *expression.Schema) (size float64) { | |||
There was a problem hiding this comment.
Can we reuse the avgRowSize function of the PhysicalHashJoin?
lzmhhh123
added
status/can-merge
|
/run-all-tests |
|
@wshwsh12 merge failed. |
|
/rebuild |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Consider disk cost in Sort.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note