Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: make CLUSTER_SLOW_QUERY support query slow log at any time #14878

Merged
merged 8 commits into from
Feb 21, 2020

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs crazycs520@gmail.com

What problem does this PR solve?

This PR is the last step of #14748.

  • Make table CLUSTER_SLOW_QUERY support query slow-log at any time.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

Release note

  • Support query CLUSTER_SLOW_QUERY and SLOW_QUERY at any time.

Signed-off-by: crazycs <crazycs520@gmail.com>
@crazycs520 crazycs520 added this to the v4.0.0-beta.1 milestone Feb 20, 2020
@crazycs520 crazycs520 requested a review from a team as a code owner February 20, 2020 13:33
@ghost ghost requested review from eurekaka and lzmhhh123 and removed request for a team February 20, 2020 13:33
@eurekaka eurekaka removed their request for review February 21, 2020 01:16
infoschema/tables_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@lonng
Copy link
Contributor

lonng commented Feb 21, 2020

lgtm

@crazycs520
Copy link
Contributor Author

/rebuild

1 similar comment
@crazycs520
Copy link
Contributor Author

/rebuild

Copy link
Contributor

@reafans reafans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@reafans reafans added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Feb 21, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 21, 2020

/run-all-tests

@sre-bot sre-bot merged commit dc2889d into pingcap:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants