-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privilege: fix compatibility of DBIsVisible (#14862) #14939
Merged
sre-bot
merged 3 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-8431c1025863
Mar 14, 2020
Merged
privilege: fix compatibility of DBIsVisible (#14862) #14939
sre-bot
merged 3 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-8431c1025863
Mar 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
jackysp
reviewed
Feb 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
tiancaiamao
approved these changes
Feb 26, 2020
ngaut
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Feb 27, 2020
/merge |
Your auto merge job has been accepted, waiting for 15365 |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/privilege
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/compatibility
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #14862 to release-3.0
What problem does this PR solve?
User with
trigger/references/execute
global privileges can not see all database names and use them, but in MySQL is okay.in TiDB:
in MySQL:
What is changed and how it works?
add
TriggerPriv
,EcecutePriv
,ReferencePriv
intoglobalDBVisible
Check List
Tests
Code changes
Side effects
Related changes
Release note