Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan, expression: add date function support for hash partition #15068

Merged
merged 2 commits into from
Mar 18, 2020
Merged

plan, expression: add date function support for hash partition #15068

merged 2 commits into from
Mar 18, 2020

Conversation

imtbkcat
Copy link

@imtbkcat imtbkcat commented Mar 2, 2020

What problem does this PR solve?

After refactor hash partition pruning logic, hash partition doesn't support builtin function yet. This PR add logic to support builtin function relating to date and time.

What is changed and how it works?

Support YEAR, MONTH, TO_DAY in hash partition.

Check List

Tests

  • Unit test

Code changes

  • None

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note

@imtbkcat imtbkcat added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner component/expression needs-cherry-pick-3.0 labels Mar 2, 2020
@imtbkcat imtbkcat requested a review from a team as a code owner March 2, 2020 12:03
@ghost ghost requested review from qw4990 and XuHuaiyu and removed request for a team March 2, 2020 12:03
@XuHuaiyu XuHuaiyu removed their request for review March 16, 2020 06:59
qw4990
qw4990 reviewed Mar 16, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 16, 2020
qw4990
qw4990 reviewed Mar 16, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we can create issues for these scalar functions which can support FastLocateHashPartition, and put these issues into UCP and let contributors help us finish them.

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 18, 2020
tiancaiamao
tiancaiamao previously approved these changes Mar 18, 2020
View reviewed changes
@tiancaiamao
Copy link
Contributor

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2020

@imtbkcat merge failed.

@codecov
Copy link

codecov bot commented Mar 18, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@4481006). Click here to learn what that means.
The diff coverage is 81.8181%.

@@             Coverage Diff             @@
##             master     #15068   +/-   ##
===========================================
  Coverage          ?   80.3431%           
===========================================
  Files             ?        502           
  Lines             ?     133816           
  Branches          ?          0           
===========================================
  Hits              ?     107512           
  Misses            ?      17846           
  Partials          ?       8458

@imtbkcat
Copy link
Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2020

/run-all-tests

@sre-bot sre-bot merged commit 7a51cb6 into pingcap:master Mar 18, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Mar 18, 2020
@sre-bot
cherry pick pingcap#15068 to release-3.0
14dedd2 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Mar 18, 2020
Closed
@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2020

cherry pick to release-3.0 in PR #15452

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Mar 18, 2020
@sre-bot
cherry pick pingcap#15068 to release-3.1
f936b67 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot mentioned this pull request Mar 18, 2020
Closed
@sre-bot
Copy link
Contributor

sre-bot commented Mar 18, 2020

cherry pick to release-3.1 in PR #15453

imtbkcat pushed a commit to imtbkcat/tidb that referenced this pull request Mar 24, 2020
plan, expression: add date function support for hash partition (pingc…
cb298ac 
…ap#15068)
@imtbkcat imtbkcat mentioned this pull request Mar 24, 2020
Merged
imtbkcat pushed a commit to imtbkcat/tidb that referenced this pull request Mar 24, 2020
plan, expression: add date function support for hash partition (pingc…
89ba7a4 
…ap#15068)
@imtbkcat imtbkcat mentioned this pull request Mar 24, 2020
Merged
sre-bot pushed a commit that referenced this pull request Mar 25, 2020
plan, expression: add date function support for hash partition (#15068)…
dc1152c 
… (#15618)
sre-bot pushed a commit that referenced this pull request Mar 25, 2020
plan, expression: add date function support for hash partition (#15068)…
df56205 
… (#15619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
component/expression sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imtbkcat @tiancaiamao @sre-bot @qw4990