*: support reload tls used by mysql protocol in place (#14749) #15080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
component/server
security
|
/run-all-tests |
lysu
reviewed
Mar 3, 2020
|
|
||
| tlsConfig, err := util.LoadTLSCertificates(s.cfg.Security.SSLCA, s.cfg.Security.SSLKey, s.cfg.Security.SSLCert) | ||
| if err != nil { | ||
| logutil.Logger(context.Background()).Error("secure connection cert/key/ca load fail", zap.Error(err)) |
There was a problem hiding this comment.
differ to master, it doesn't return error to compatible with old 3.0
|
/run-all-tests |
|
@jackysp @tiancaiamao conflict has be resolved and keep compatible with old 3.0 keep work if tls config is wrong, PTAL if free |
|
LGTM |
tiancaiamao
added
status/LGT2
tiancaiamao
approved these changes
Mar 4, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for 15092 |
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
Sorry @imtbkcat, you don't have permission to trigger auto merge event on this branch. |
|
/merge |
|
Sorry @lysu, you don't have permission to trigger auto merge event on this branch. |
|
/rebuild |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #14749 to release-3.0
What problem does this PR solve?
ref #14666
preliminary support reload tls used by mysql protocol
this PR doesn't try to full support mysql's dynamic modify "ssl_ca/ssl_key/ssl_cert" value, but can reload tls used old file path specified by old "ssl_ca/ssl_key/ssl_cert" value(so ssl_cert/ssl_ca/ssl_key keep read-only after this PR).
so user can:
alter instance reload tlsthen all new db connection will use new cert file, old connection will keep work just like mysql does
What is changed and how it works?
LoadTLSCertificatesserver.tlsConfigcan be atomic swapCheck List
Tests
Code changes
Side effects
Related changes
Release note
This change is