Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: reload tikv/tidb cluster tls for every new established conn (#14833) #15162

Merged
merged 2 commits into from
Mar 17, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 5, 2020

cherry-pick #14833 to release-3.0


What problem does this PR solve?

support reload cluster TLS cert/key file used by TiKV or TiDB-self(CA still can not be hot-reload now)

pd's cert/key will be handled by new pdclient

What is changed and how it works?

reload TLS for every new connection(include grpc auto retry in resetTransport) like etcd

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

Code changes

  • change conf way

Side effects

  • n/a

Related changes

  • n/a

Release note

  • reload tikv/tidb cluster tls for every new established conn

This change is Reviewable

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 5, 2020

/run-all-tests

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor

LGTM

tiancaiamao
tiancaiamao previously approved these changes Mar 10, 2020
@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 10, 2020
@zz-jason
Copy link
Member

@lysu please resolve conflicts.

@jackysp
Copy link
Member

jackysp commented Mar 17, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 17, 2020

/run-all-tests

@sre-bot sre-bot merged commit c668b94 into pingcap:release-3.0 Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config component/tikv security Everything related with security status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants