-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: migrate dataForTables
and dataForPartitions
from package infoschema
to executor
#15034 #15037
#15208
Conversation
Thanks for your contribution. If your PR get merged, you will be rewarded 50 points. |
Codecov Report
@@ Coverage Diff @@
## master #15208 +/- ##
===========================================
Coverage 80.5196% 80.5196%
===========================================
Files 503 503
Lines 133776 133776
===========================================
Hits 107716 107716
Misses 17686 17686
Partials 8374 8374 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/award-point 100 |
Update score success, the task will rewarded 100 after merged. |
/run-check_dev_2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
Congratulation! You have awarded a badge for usability challenge program! Please fill the form to get your reward! http://tidbcommunity.mikecrm.com/QMCv4QL |
UCP #15034
UCP #15037
What problem does this PR solve?
migrate
dataForTables
anddataForPartitions
from packageinfoschema
toexecutor
What is changed and how it works?
Infoschema contains too much logic for retrieving data, which is confusing, we need to migrate this part to the executor so that infoshema only contains schema information. Detail ref #15034
and #15037
Check List
Tests
Code changes