Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: fix timing of prewrite binlog in slow log (#15273) #15276

Merged
merged 1 commit into from
Mar 11, 2020
Merged

store: fix timing of prewrite binlog in slow log (#15273) #15276

merged 1 commit into from
Mar 11, 2020

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Mar 11, 2020 •
edited
Loading

What problem does this PR solve?

Cherry pick #15273 to release 3.0

Release note

  • Write release note for bug-fix or new feature.
    Fix timing of prewrite binlog Binlog_prewrite_time in slow log to make it accurate.

@jackysp jackysp added type/3.0-cherry-pick type/bugfix This PR fixes a bug. type/enhancement The issue or PR belongs to an enhancement. labels Mar 11, 2020
@jackysp jackysp requested review from cfzjywxk and lysu March 11, 2020 03:23
lysu
lysu reviewed Mar 11, 2020
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cfzjywxk
cfzjywxk approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Mar 11, 2020
@jackysp
Copy link
Member Author

jackysp commented Mar 11, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 11, 2020

/run-all-tests

@sre-bot sre-bot merged commit e4b30a4 into pingcap:release-3.0 Mar 11, 2020
@jackysp jackysp added the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label Mar 12, 2020
@jackysp jackysp deleted the fix_binglog_prewrite_3.0 branch November 25, 2020 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@cfzjywxk cfzjywxk cfzjywxk approved these changes

Assignees
No one assigned
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackysp @sre-bot @lysu @cfzjywxk