executor: use deep copy for maxMin4JSON (#15242) #15289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
sig/execution
SunRunAway
reviewed
Mar 11, 2020
executor/aggregate_test.go
Outdated
| @@ -752,3 +752,46 @@ func (s *testSuite1) TestIssue10608(c *C) { | |||
| tk.MustQuery("select (select group_concat(concat(123,'-')) from t where t.a = s.b group by t.a) as t from s;").Check(testkit.Rows("123-", "123-")) | |||
|
|
|||
| } | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Please resolve the conflicts. @fzhedu
solve confilcts.
|
/rebuild |
SunRunAway
reviewed
Mar 11, 2020
executor/aggregate_test.go
Outdated
| @@ -752,3 +752,43 @@ func (s *testSuite1) TestIssue10608(c *C) { | |||
| tk.MustQuery("select (select group_concat(concat(123,'-')) from t where t.a = s.b group by t.a) as t from s;").Check(testkit.Rows("123-", "123-")) | |||
|
|
|||
| } | |||
|
|
|||
| func (s *testSuiteAgg) TestIssue12759HashAggCalledByApply(c *C) { | |||
There was a problem hiding this comment.
This test case is useless in 3.0 branch, see #12766 (comment)
solve confilcts.
zimulala
reviewed
Mar 12, 2020
executor/aggregate_test.go
Outdated
| @@ -752,3 +752,17 @@ func (s *testSuite1) TestIssue10608(c *C) { | |||
| tk.MustQuery("select (select group_concat(concat(123,'-')) from t where t.a = s.b group by t.a) as t from s;").Check(testkit.Rows("123-", "123-")) | |||
|
|
|||
| } | |||
|
|
|||
| func (s *testSuiteAgg) TestPR15242ShallowCopy(c *C) { | |||
There was a problem hiding this comment.
Please fix this issue:"executor/aggregate_test.go:756:10: undefined: testSuiteAgg"
change testSuitAgg -> testSuit
wshwsh12
added
status/LGT2
|
Sorry @wshwsh12, you don't have permission to trigger auto merge event on this branch. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15242 to release-3.0
What problem does this PR solve?
fix #15278
What is changed and how it works?
change shallow copy to deep copy
Check List
Tests
use large dataset to reproduce this problem.
Code changes
Side effects
Related changes
Release note