*: support require-secure-transport startup option #15341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysu
added
component/server
needs-cherry-pick-3.0
component/config
security
ghost
requested review from
SunRunAway and
wshwsh12
and removed request for
a team
|
/run-all-tests |
lysu
requested review from
kolbe and
jackysp
and removed request for
SunRunAway and
wshwsh12
|
/run-unit-test |
jackysp
reviewed
Mar 12, 2020
jackysp
reviewed
Mar 12, 2020
| nmPluginLoad = "plugin-load" | ||
| nmRepairMode = "repair-mode" | ||
| nmRepairList = "repair-list" | ||
| nmRequireSecureTransport = "require-secure-transport" |
There was a problem hiding this comment.
I know it is the same name as MySQL's, but I'm not sure adding it is approved.
\cc @siddontang
There was a problem hiding this comment.
I use mysql --help but don't find hat it uses this in command flags.
There was a problem hiding this comment.
It is a flag of mysqld, try mysqld --verbose --help
kolbe
reviewed
Mar 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #15341 +/- ##
===============================================
+ Coverage 80.532% 80.6704% +0.1383%
===============================================
Files 502 503 +1
Lines 134534 135968 +1434
===============================================
+ Hits 108343 109686 +1343
- Misses 17765 17845 +80
- Partials 8426 8437 +11 |
52 tasks
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 17, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #15415 |
sre-bot
added a commit
that referenced
this pull request
Mar 18, 2020
sre-bot
added a commit
that referenced
this pull request
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #15306
What is changed and how it works?
--require-secure-transportstartup optionrequire-secure-transportbe enabledrequire-secure-transportbe enabled but no avaliable cert/key/carequire-secure-transportbe enabled event if withno rollback on errorCheck List
Tests
Code changes
Side effects
Related changes
tidb-ansiblerepositoryRelease note
This change is