Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix behavior for CASE WHEN (not_int) (#15309) #15359

Merged
merged 1 commit into from
Mar 14, 2020
Merged

expression: fix behavior for CASE WHEN (not_int) (#15309) #15359

merged 1 commit into from
Mar 14, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 13, 2020

cherry-pick #15309 to release-3.0

What problem does this PR solve?

fix #15291

What is changed and how it works?

using wrapWithIsTrue to wrap condition expressions.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 13, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Mar 13, 2020
Merged
@sre-bot sre-bot added component/expression contribution This PR is from a community contributor. type/3.0-cherry-pick labels Mar 13, 2020
@SunRunAway
Copy link
Contributor

LGTM

@SunRunAway SunRunAway added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 13, 2020
@wshwsh12 wshwsh12 removed their request for review March 13, 2020 08:17
zz-jason
zz-jason approved these changes Mar 14, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 9855c8f into pingcap:release-3.0 Mar 14, 2020
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @SunRunAway @zz-jason @lance6716