ddl: add syntax for setting the cache step of auto id explicitly. #15409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
wshwsh12 and
XuHuaiyu
and removed request for
a team
github-actions
bot
added
sig/sql-infra
|
This PR need parser merged first |
Codecov Report
@@ Coverage Diff @@
## master #15409 +/- ##
===========================================
Coverage 80.6188% 80.6188%
===========================================
Files 506 506
Lines 137226 137226
===========================================
Hits 110630 110630
Misses 18092 18092
Partials 8504 8504 |
bb7133
changed the title
bb7133
reviewed
Mar 18, 2020
Deardrops
reviewed
Mar 18, 2020
|
LGTM |
AilinKid
requested review from
tangenta and
Deardrops
and removed request for
tangenta
Deardrops
reviewed
Apr 3, 2020
|
/run-all-tests |
|
/run-sqllogic-test-2 |
|
/run-all-tests |
|
/run-check_dev_2 |
AilinKid
added
status/all-tests-passed
status/LGT3
bb7133
approved these changes
Apr 10, 2020
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-2.1 in PR #16286 |
|
cherry pick to release-3.0 in PR #16287 |
|
cherry pick to release-3.1 in PR #16288 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 10, 2020
|
cherry pick to release-4.0 in PR #16289 |
AilinKid
added a commit
to sre-bot/tidb
that referenced
this pull request
Apr 26, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
sre-bot
added a commit
that referenced
this pull request
Apr 26, 2020
AilinKid
added a commit
to sre-bot/tidb
that referenced
this pull request
Apr 28, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
bb7133
pushed a commit
that referenced
this pull request
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
That autoid allocator's cache step is quite big now, it will consume a lot of autoid when tidb restarts or crashes. For those scenes which treasure autoid heavily, it's not acceptable.
Parser link: #765
Problem Summary:
What is changed and how it works?
Add
auto_increment_cachein create table / alter table statement and it will determine the allocator's cache step.But there is an exception when a statement like an insert batch(
insert into values()()...) which requires allocating consecutive N autoid in one statement, we will make sure that the custom cache step is adequate for it withif step < N, then step = min(2N, maxstep)Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tidb-ansible:Check List
Tests
Release note:
ddl: add syntax for setting the cache step of auto id explicitly.