*: use https protocol between tidb-pd tidb-tidb when cluster-ssl configured (#15342) #15419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
sre-bot
added
sig/sql-infra
lysu
force-pushed
the
release-3.0-a97787562319
branch
from
0ac6cc8
to
35565a0
Compare
lysu
added
the
priority/release-blocker
|
@jackysp PTAL |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-unit-test |
|
cherry pick to release-3.1 in PR #15430 |
sre-bot
added a commit
that referenced
this pull request
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15342 to release-3.0
What problem does this PR solve?
fixes #15120
PD or TiDB RESTful service will require https when cluster configured with cluster-ssl-*, but tidb-server only can send http request.
What is changed and how it works?
change to https client when "cluster-ssl-*" configured
Check List
Tests
configure pd/tidb/tikv as https://pingcap.com/docs/stable/how-to/secure/enable-tls-between-components/
then try to use TiDB http-api or "cluster table"
Code changes
Side effects
Related changes
Need to cherry-pick to the release branch
Release note
use https request between tidb-pd tidb-tidb when cluster-ssl configured.
This change is