Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix error when select view_name.col_name from view_name(#14314) #15572

Merged
merged 2 commits into from
Mar 24, 2020
Merged

planner: fix error when select view_name.col_name from view_name(#14314) #15572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b0199e
planner: fix error when select view_name.col_name from view_name(#14314)
XuHuaiyu Mar 23, 2020
67dd241
Merge branch 'release-3.0' into release-3.0
sre-bot Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion planner/core/logical_plan_builder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2426,7 +2426,7 @@ func (b *PlanBuilder) buildProjUponView(ctx context.Context, dbName model.CIStr,
}
projSchema.Append(&expression.Column{
UniqueID: b.ctx.GetSessionVars().AllocPlanColumnID(),
TblName: col.TblName,
TblName: tableInfo.Name,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change DBName?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XuHuaiyu PTAL. BTW, we can merge this PR firstly. Changing the DBName in another PR if needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.
#15611

OrigTblName: col.OrigTblName,
ColName: columnInfo[i].Name,
OrigColName: origColName,
Expand Down
4 changes: 4 additions & 0 deletions planner/core/logical_plan_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2227,6 +2227,10 @@ func (s *testPlanSuite) TestSelectView(c *C) {
sql: "select * from v",
best: "DataScan(t)->Projection",
},
{
sql: "select v.b, v.c, v.d from v",
best: "DataScan(t)->Projection",
},
}
ctx := context.TODO()
for i, tt := range tests {
Expand Down