Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add the tid to the schema-change related tables only when keys need to be locked (#15698) #15707

Merged
merged 2 commits into from
Mar 27, 2020

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Mar 26, 2020

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
Cherry pick #15698 to release 3.0

Release note

Add the table ID to the schema-change related tables only when keys need to be locked in select for update statement.

@jackysp jackysp added type/bugfix This PR fixes a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. type/3.0-cherry-pick labels Mar 26, 2020
@github-actions github-actions bot added the sig/execution SIG execution label Mar 26, 2020
@jackysp jackysp added the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label Mar 26, 2020
Copy link
Contributor

@cfzjywxk cfzjywxk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtbkcat imtbkcat added the status/can-merge Indicates a PR has been approved by a committer. label Mar 27, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 27, 2020

Sorry @imtbkcat, you don't have permission to trigger auto merge event on this branch.

@jackysp
Copy link
Member Author

jackysp commented Mar 27, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 27, 2020

/run-all-tests

@sre-bot sre-bot merged commit 60c49e5 into pingcap:release-3.0 Mar 27, 2020
@jackysp jackysp deleted the fix_pess_schema_change_3.0 branch November 25, 2020 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants