config, server: change the default value of max-server-connections #15726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimulala
added
type/enhancement
|
PTAL @jackysp |
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## master #15726 +/- ##
===========================================
Coverage 80.4092% 80.4092%
===========================================
Files 504 504
Lines 134967 134967
===========================================
Hits 108526 108526
Misses 17965 17965
Partials 8476 8476 |
AilinKid
approved these changes
Mar 26, 2020
zimulala
added
status/can-merge
|
/run-all-tests |
|
@zimulala merge failed. |
|
/run-all-tests |
|
/run-integration-common-test |
|
/merge |
|
/run-all-tests |
|
@zimulala merge failed. |
|
/run-check_dev_2 |
|
cherry pick to release-4.0 in PR #15730 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
max-server-connectionsis added in #14409, and some users may think this value is too small.What is changed and how it works?
What's Changed:
Change the default value of max-server-connections to 0, and if the value is 0, the number of connections is unlimited.
Related changes
pingcap/docs/pingcap/docs-cn: reference: updatemax-server-connectionsdocs-cn#2574pingcap/tidb-ansible:Check List
Tests
Release note