executor: check unequal handles when buildTableReader4INLJoin (#15675) #15734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
sig/execution
qw4990
added
status/LGT2
fzhedu
reviewed
Apr 1, 2020
| for _, content := range lookUpContents { | ||
| handles = append(handles, content.keys[0].GetInt64()) | ||
| handle := content.keys[0].GetInt64() |
There was a problem hiding this comment.
if there is only one keys in each content, properly true in most cases, it is no need to use this loop.
SunRunAway
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 15806 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15675 to release-3.0
What problem does this PR solve?
Issue Number: close #15658
Problem Summary:
Before this commit, buildTableReaderForIndexJoin assumes that there is only one value for handles in lookupContent. Thus we'll fetch redundant rows.
What is changed and how it works?
Proposal: xxx
What's Changed:
Check whether there are redundant unequal
handlevalues in buildTableReaderForIndexJoin.How it Works:
Related changes
Check List
Tests
Side effects
Release note