Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunk: make mysql.TypeNull be judged as fixedLen (#15512) #15739

Merged
merged 3 commits into from
Apr 3, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 26, 2020

cherry-pick #15512 to release-3.1


What problem does this PR solve?

Issue Number: close #6252

Problem Summary:

What is changed and how it works?

fix:

MySQL [test]> create table t2(a int);
Query OK, 0 rows affected (0.013 sec)
MySQL [test]> create table t1(a int);
Query OK, 0 rows affected (0.011 sec)
MySQL [test]> insert into t1(a) select 1;
Query OK, 1 row affected (0.004 sec)
Records: 1 Duplicates: 0 Warnings: 0
MySQL [test]> select b.n from t1 left join (select a as a, null as n from t2) b on b.a = t1.a order by t1.a;
ERROR 1105 (HY000): runtime error: index out of range [1] with length 1

What's Changed:

try let TypeNull as fixedLen column in the chunk

How it Works:

try let TypeNull as fixedLen column in the chunk

Related changes

  • Need to cherry-pick to the release branch: same problem in 2.1/3.0

Check List

Tests

WIP

  • Unit test
  • Integration test

Side effects

  • n/a

Release note

fix panic when sort/topn above left join with null column in right child


This change is Reviewable

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 26, 2020

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lysu please resolve conflicts

@lysu
Copy link
Contributor

lysu commented Mar 31, 2020

/run-all-tests

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 3, 2020
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 3, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 3, 2020

/run-all-tests

@sre-bot sre-bot merged commit b19a940 into pingcap:release-3.1 Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants