Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan: do not cache plan for query on range partition table (#15697) #15818

Merged
merged 3 commits into from
Apr 7, 2020
Merged

plan: do not cache plan for query on range partition table (#15697) #15818

merged 3 commits into from
Apr 7, 2020

Conversation

imtbkcat
Copy link

What problem does this PR solve?

cherry-pick #15697

eurekaka
eurekaka reviewed Mar 30, 2020
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason previously approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Mar 30, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

Your auto merge job has been accepted, waiting for 15728

@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

@imtbkcat merge failed.

@tiancaiamao
Copy link
Contributor

gofmt fail @imtbkcat

@zz-jason zz-jason removed the request for review from jackysp April 4, 2020 06:59
@imtbkcat
Copy link
Author

imtbkcat commented Apr 7, 2020

@tiancaiamao ci fixed, need approve.

jackysp
jackysp approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@jackysp
Copy link
Member

jackysp commented Apr 7, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2020

Your auto merge job has been accepted, waiting for 16064

@sre-bot
Copy link
Contributor

sre-bot commented Apr 7, 2020

/run-all-tests

@sre-bot sre-bot merged commit 77548e9 into pingcap:release-3.0 Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@jackysp jackysp jackysp approved these changes

@zz-jason zz-jason zz-jason left review comments

Assignees

@imtbkcat imtbkcat

Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@imtbkcat @sre-bot @tiancaiamao @jackysp @zz-jason @eurekaka