Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinJSONSearchSig #15859

Merged
merged 38 commits into from
Apr 15, 2020
Merged

expression: implement vectorized evaluation for builtinJSONSearchSig #15859

merged 38 commits into from
Apr 15, 2020

Conversation

zhaox1n
Copy link
Contributor

@zhaox1n zhaox1n commented Mar 30, 2020

UCP #12104

What problem does this PR solve?

implement vectorized evaluation for builtinJSOSearchSig

What is changed and how it works?

BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-VecBuiltinFunc-12                           1408           1227651 ns/op         1138688 B/op      10240 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-NonVecBuiltinFunc-12                        1076           1158112 ns/op         1138689 B/op      10240 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-VecBuiltinFunc#01-12                         250           4691324 ns/op         2035133 B/op      34837 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-NonVecBuiltinFunc#01-12                      249           4570834 ns/op         2035084 B/op      34837 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-VecBuiltinFunc#02-12                         232           4946785 ns/op         2035053 B/op      34837 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-NonVecBuiltinFunc#02-12                      288           5029420 ns/op         2035164 B/op      34838 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-VecBuiltinFunc#03-12                         278           4720992 ns/op         2067925 B/op      35863 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-NonVecBuiltinFunc#03-12                      241           4428660 ns/op         2068002 B/op      35862 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-VecBuiltinFunc#04-12                         254           4857389 ns/op         2035008 B/op      34837 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-NonVecBuiltinFunc#04-12                      247           4749373 ns/op         2035179 B/op      34838 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-VecBuiltinFunc#05-12                         306           3730100 ns/op         1862828 B/op      21505 allocs/op
BenchmarkVectorizedBuiltinJSONFunc/builtinJSONSearchSig-NonVecBuiltinFunc#05-12                      302           3708237 ns/op         1862739 B/op      21504 allocs/op

Check List

Tests

  • Unit test

zhaox1n and others added 22 commits March 12, 2020 21:39
@zhaox1n zhaox1n requested a review from a team as a code owner March 30, 2020 12:13
@sre-bot
Copy link
Contributor

sre-bot commented Mar 30, 2020

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Mar 30, 2020
@ghost ghost requested review from wshwsh12 and removed request for a team March 30, 2020 12:13
@zhaox1n
Copy link
Contributor Author

zhaox1n commented Apr 13, 2020

PTAL @qw4990

qw4990
qw4990 reviewed Apr 14, 2020
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @zhaox1n , and PTAL @wshwsh12 .

@qw4990
Copy link
Contributor

qw4990 commented Apr 14, 2020

/rebuild

@qw4990 qw4990 added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 14, 2020
@wshwsh12 wshwsh12 self-requested a review April 14, 2020 03:45
wshwsh12
wshwsh12 approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 14, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

Your auto merge job has been accepted, waiting for 16175, 16232, 16233, 15738, 16132, 16133, 16218, 15585, 16263, 15357

@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

@zhaox1n merge failed.

@qw4990
Copy link
Contributor

qw4990 commented Apr 14, 2020

/run-all-tests

@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

Your auto merge job has been accepted, waiting for 16175, 16347

@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Apr 14, 2020

@zhaox1n merge failed.

@zhaox1n
Copy link
Contributor Author

zhaox1n commented Apr 14, 2020

/run-all-tests

@wshwsh12
Copy link
Contributor

/run-all-tests

@zz-jason zz-jason merged commit 7cc2c70 into pingcap:master Apr 15, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

Team zhaox1n complete task #12104 and get 50 score, currerent score 200.

@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

Congratulations, you get 200 score from easy level tasks in challenge program season-2, and if your PRs in reviewed stage all got merged, the score will be 200, try some medium and hard tasks!(you can not reward from easy and vector tasks now)

sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Apr 15, 2020
@zhaox1n @sre-bot
expression: implement vectorized evaluation for `builtinJSONSe… (ping…
8f0f8ea 
…cap#15859)
@sre-bot sre-bot mentioned this pull request Apr 15, 2020
Merged
@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

cherry pick to release-4.0 in PR #16382

@zhaox1n zhaox1n deleted the builtinJSONSearchSig branch April 15, 2020 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhaox1n @sre-bot @qw4990 @zz-jason @wshwsh12