statistic: fix error when fast analyze on only indexes #15889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzmhhh123
added
type/bugfix
ghost
removed their request for review
ghost
removed their request for review
Codecov Report
@@ Coverage Diff @@
## master #15889 +/- ##
===========================================
Coverage ? 80.5492%
===========================================
Files ? 505
Lines ? 135301
Branches ? 0
===========================================
Hits ? 108984
Misses ? 17836
Partials ? 8481 |
lzmhhh123
added
the
priority/release-blocker
francis0407
added
the
status/can-merge
|
/merge |
|
Your auto merge job has been accepted, waiting for 15907, 15845, 15758, 15956, 15776 |
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/run-sqllogic-test |
francis0407
approved these changes
Apr 1, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for 15955, 15860, 15868, 15907, 15956 |
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/run-check_dev_2 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 1, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #15967 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 1, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #15968 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 1, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #15969 |
zz-jason
pushed a commit
that referenced
this pull request
Apr 1, 2020
zz-jason
pushed a commit
that referenced
this pull request
Apr 1, 2020
sre-bot
added a commit
that referenced
this pull request
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #15752
Problem Summary: in the fast sample, we use the wrong column info to build index value. When we only analyze indexes, the analyzing column infos is nil. Then we should use table info's columns to build index value.
What is changed and how it works?
What's Changed: change
colInfostotblInfo.ColumnsRelated changes
Check List
Tests