Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: remove the NotNullFlag for aggregation func MAX/MIN when inferring type (#11343) #16140

Closed

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 8, 2020

cherry-pick #11343 to release-2.1


What problem does this PR solve?

Fix issue #11332

What is changed and how it works?

IF scalefunc is MAX or MIN, remove not null flag.

Check List

Tests

  • Unit test

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 8, 2020

/run-all-tests

@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Apr 8, 2020

This problem does not exist in release-2.1, so close this PR.

@XuHuaiyu XuHuaiyu closed this Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. type/bugfix This PR fixes a bug. type/2.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants