Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: disable int_col <cmp> non-int const folding for plan cache (#14120) #16184

Merged
merged 5 commits into from
Apr 9, 2020
Merged

expression: disable int_col <cmp> non-int const folding for plan cache (#14120) #16184

merged 5 commits into from
Apr 9, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 8, 2020

cherry-pick #14120 to release-3.0

What problem does this PR solve?

Fix #13240

What is changed and how it works?

Disable refineArgs when prepare plan cache is enabled and any argument contains deferred expressions.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Write release note for bug-fix or new feature.

@eurekaka @sre-bot
cherry pick pingcap#14120 to release-3.0
b5e1bc5 
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 8, 2020

/run-all-tests

@sre-bot sre-bot mentioned this pull request Apr 8, 2020
Merged
@sre-bot sre-bot added sig/planner SIG: Planner type/3.0-cherry-pick type/bugfix This PR fixes a bug. labels Apr 8, 2020
wshwsh12
wshwsh12 reviewed Apr 8, 2020
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zz-jason
zz-jason approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Apr 9, 2020
@zz-jason zz-jason removed the request for review from qw4990 April 9, 2020 01:16
@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 9, 2020

/run-all-tests

@sre-bot sre-bot merged commit 5ca3fde into pingcap:release-3.0 Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/expression sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @zz-jason @wshwsh12 @eurekaka