server: if status address already in use, return an error (#15177) #16291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
component/server
type/3.1-cherry-pick
type/enhancement
zimulala
force-pushed
the
release-3.1-f8b2d9676492
branch
from
f382dff
to
970fcc6
Compare
zimulala
added
status/can-merge
|
/run-all-tests |
AilinKid
approved these changes
Apr 10, 2020
|
@sre-bot merge failed. |
|
/run-common-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15177 to release-3.1
conflicting files:
server/http_status.go
server/server.go
server/tidb_test.go
What problem does this PR solve?
If the status address already in use, we only log it. We don't know why the status server is unavailable except by looking at the logs.
If we don't start the status server, we can set
report-statusto false.What is changed and how it works?
If the status address already in use, we return an error and interrupt the service.
Check List
Tests
Related changes
Release note