*: fix a bug caused by the wrong collation setting which leads to the wrong result of collation function #17116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #17116 +/- ##
===========================================
Coverage 80.9240% 80.9240%
===========================================
Files 511 511
Lines 144863 144863
===========================================
Hits 117229 117229
Misses 18658 18658
Partials 8976 8976 |
bb7133
reviewed
May 12, 2020
| var ok bool | ||
| var charsetVal string | ||
| var err2 error | ||
| if name == CollationConnection { |
There was a problem hiding this comment.
Double switch makes the code complicated.
I think it's fine since there are only three branches. If four, then I will use switch
qw4990
reviewed
May 12, 2020
bb7133
added
status/LGT2
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
|
/run-unit-test |
|
/merge |
|
/run-all-tests |
qw4990
approved these changes
May 15, 2020
|
/merge |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
/merge |
|
@wjhuang2016 merge failed. |
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 15, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #17231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17115
Problem Summary:
collation_connectionif the collate is illegal.collationfunction shouldn't use the argument's collation, or it will lead to unreadable binary output if the collation isbinary.What is changed and how it works?
collation_connectionforcollationfunction.Related changes
Check List
Tests
Side effects
Release note