Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: fix the allocator batch size compute logic (#17271) #17548

Merged
merged 3 commits into from
Jun 1, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jun 1, 2020

cherry-pick #17271 to release-3.0


What problem does this PR solve?

Problem Summary: fix logic in allocator batch size computation

What is changed and how it works?

What's Changed:
when the local cache size if not enough for allocN, do the new batchSize computation based on the global new base in the txn.

so we postpone the NextStep adjustment to meta txn and store it after that.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Release note

  • meta: fix the allocator batch size compute logic

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 1, 2020

/run-all-tests

@sre-bot sre-bot added sig/sql-infra SIG: SQL Infra priority/release-blocker This issue blocks a release. Please solve it ASAP. type/3.0-cherry-pick type/bugfix This PR fixes a bug. labels Jun 1, 2020
@sre-bot sre-bot added this to the v3.0.15 milestone Jun 1, 2020
.
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid
Copy link
Contributor

AilinKid commented Jun 1, 2020

/run-all-tests

@AilinKid
Copy link
Contributor

AilinKid commented Jun 1, 2020

/run-mybatis-test

1 similar comment
@AilinKid
Copy link
Contributor

AilinKid commented Jun 1, 2020

/run-mybatis-test

Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any conflicts? Please list them.

@AilinKid
Copy link
Contributor

AilinKid commented Jun 1, 2020

conflict files

autoid.go: move useless code
autoid_test.go: s/mockStore()/mockTikvStore() 

Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Jun 1, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented Jun 1, 2020

/run-all-tests

@sre-bot sre-bot merged commit 47571bc into pingcap:release-3.0 Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants