executor: stop using the deprecated Filter field in BRIE statements #18172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @wjhuang2016 |
Data race |
|
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #18172 +/- ##
===========================================
Coverage 79.5462% 79.5462%
===========================================
Files 535 535
Lines 144712 144712
===========================================
Hits 115113 115113
Misses 20324 20324
Partials 9275 9275 |
|
PTAL @bb7133 |
|
/merge |
bb7133
added
the
status/can-merge
qw4990
added
status/can-merge
|
/merge |
|
/run-all-tests |
|
@kennytm merge failed. |
|
/run-all-tests |
|
/run-integration-copr-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 24, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #18764 |
kennytm
added a commit
to kennytm/tidb
that referenced
this pull request
Jul 24, 2020
…ingcap#18172) Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #18151
Problem Summary:
In pingcap/br#313, we have deprecated the fields
FilterandCaseSensitivein theConfigstructure (they are not immediately removed due to cyclic dependency). Their usages are supposed to be removed in the when TiDB upgrades the BR dependency.The Go language founders hate warnings, and thus the Go compiler will not warn about use of deprecated items. This has to be checked by third-party linters such as staticcheck. Unforuntately SA1019 is not enabled by default. Therefore, the lint is completely ignored in #17839. Because BRIE statement does not support mocktikv, we can't rely on unit tests either. This leads to #18151 slipping into the master branch.
What is changed and how it works?
What's Changed:
As a hot-fix, we removed all use of Filter and CaseSensitive fields by the TableFilter field.
How it Works:
Related changes
Check List
Tests
BACKUP DATABASE test TO 'noop://'in both master and this PR.Side effects
Release note