*: compatible with Go 1.14's checkptr #18189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18189 +/- ##
===========================================
Coverage 79.9187% 79.9187%
===========================================
Files 535 535
Lines 146535 146535
===========================================
Hits 117109 117109
Misses 20190 20190
Partials 9236 9236 |
bobotu
force-pushed
the
fix-tests-on-go1.14
branch
from
e329d88
to
e3d27f6
Compare
|
PTAL @tiancaiamao |
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
jackysp
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The Go 1.14 introduces new instrumentation to check that Go code is following unsafe.Pointer safety rules dynamically. The new flag -d=checkptr is enabled by default with the -race or -msan flags.
I have fixed memdb in #14972, and this PR will try to fix the remaining parts. And ngaut/unistore#402 is for unistore.
What is changed and how it works?
The newer version of
bbolthas fixed this issue, so update it to the latest version. It doesn't change the version of etcd, andbboltis only used in tests, I think it is safe to do so.For
murmur3hash package, change to https://github.com/twmb/murmur3Release note