ddl: fix admin repair table will reload fail on the other node #18285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18285 +/- ##
================================================
+ Coverage 79.4536% 79.4659% +0.0122%
================================================
Files 535 535
Lines 144274 144282 +8
================================================
+ Hits 114631 114655 +24
+ Misses 20364 20358 -6
+ Partials 9279 9269 -10 |
|
@djshow832,Thanks for you review. |
|
@bb7133,Thanks for you review. |
bb7133
added
require-LGT3
|
/run-unit-test |
zimulala
reviewed
Jul 2, 2020
infoschema/builder.go
Outdated
| @@ -75,7 +75,7 @@ func (b *Builder) ApplyDiff(m *meta.Meta, diff *model.SchemaDiff) ([]int64, erro | |||
| var allocs autoid.Allocators | |||
| if tableIDIsValid(oldTableID) { | |||
| if oldTableID == newTableID && diff.Type != model.ActionRenameTable && | |||
| diff.Type != model.ActionExchangeTablePartition { | |||
| diff.Type != model.ActionExchangeTablePartition && diff.Type != model.ActionRepairTable { | |||
There was a problem hiding this comment.
Please add a comment here.
Signed-off-by: AilinKid <314806019@qq.com>
|
/run-all-tests |
|
/run-all-tests |
Signed-off-by: AilinKid <314806019@qq.com>
|
@zimulala,Thanks for you review. |
zimulala
added
the
status/can-merge
|
Sorry @zimulala, you don't have permission to trigger auto merge event on this branch. The number of |
zimulala
added
status/LGT3
|
Sorry @zimulala, you don't have permission to trigger auto merge event on this branch. The number of |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 2, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #18323 |
zimulala
pushed a commit
that referenced
this pull request
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Now in TiDB cluster, if config one node as repair-mode node, the other node could not reload the new schema info after the table has been repaired.
The reason is because
repair-node: information schema has filtered the repaired tables, so for itself, apply the create table logic is ok.
other-node: information schema has included the repaired tables, so for them, should apply the drop table first, then create new table.
Root cause:
sortedTablesBuckets will append the new repaired table into it, when find table with
TableByID, then binary search will get the first old one rather the new one with same table ID (so should drop it first)What is changed and how it works?
How it Works: drop old table first when apply repaired table in
applydiffRelated changes
Check List
Tests
Release note