Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor,ddl: update auto_random_base in 'show create table' after insertion (#18217) #18316

Merged
merged 8 commits into from
Jul 8, 2020
Merged

executor,ddl: update auto_random_base in 'show create table' after insertion (#18217) #18316

merged 8 commits into from
Jul 8, 2020

Conversation

Rustin170506
Copy link
Member

cherry-pick #18217 to release-4.0

Signed-off-by: Rustin-Liu rustin.liu@gmail.com

What problem does this PR solve?

Issue Number: close #17456。

Problem Summary:

What is changed and how it works?

What's Changed:

Use Allocator.NextGlobalAutoID() as auto_random_base.

How it Works:

Use Allocator.NextGlobalAutoID() as auto_random_base.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

None

Release note

  • update auto_random_base in 'show create table' after insertion

@Rustin170506 @ti-srebot
cherry pick pingcap#18217 to release-4.0
baf32d2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@Rustin170506
executor: resolve conflicts
ad2b200 
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@Rustin170506
executor: resolve conflicts
b543bd5 
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Jul 1, 2020
@Rustin170506
executor: resolve conflicts
78944f9 
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@Rustin170506
executor: resolve conflicts
378417c 
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@Rustin170506 Rustin170506 changed the title Cherry executor,ddl: update auto_random_base in 'show create table' after insertion (#18217) Jul 1, 2020
@Rustin170506
executor: remove allow_auto_random_explicit_insert = true
d51cade 
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Jul 1, 2020
@AilinKid
Copy link
Contributor

AilinKid commented Jul 1, 2020

/run-all-tests

AilinKid
AilinKid reviewed Jul 1, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@AilinKid,Thanks for you review.

@AilinKid AilinKid added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 1, 2020
zimulala
zimulala reviewed Jul 2, 2020
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @tangenta

tangenta
tangenta approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 2, 2020
@ti-srebot
Copy link
Contributor

@tangenta,Thanks for you review.

@Rustin170506
Copy link
Member Author

@ti-srebot /run-all-tests

@ti-srebot
Copy link
Contributor

/run-all-tests

@Rustin170506
Copy link
Member Author

@ti-srebot /run-all-tests Just for test bot.

@ti-srebot
Copy link
Contributor

/run-all-tests Just for test bot.

@tangenta tangenta requested a review from bb7133 July 8, 2020 08:34
@tangenta tangenta added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 8, 2020
AilinKid
AilinKid approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Jul 8, 2020 

[2020-07-08T11:18:40.034Z] ----------------------------------------------------------------------
[2020-07-08T11:18:40.034Z] FAIL: sort_test.go:26: testSuite.TestSortInDisk
[2020-07-08T11:18:40.034Z] 
[2020-07-08T11:18:40.034Z] sort_test.go:60:
[2020-07-08T11:18:40.034Z]     c.Assert(tk.Se.GetSessionVars().StmtCtx.DiskTracker.MaxConsumed(), Greater, int64(0))
[2020-07-08T11:18:40.034Z] ... compare_one int64 = 0
[2020-07-08T11:18:40.035Z] ... compare_two int64 = 0
[2020-07-08T11:18:40.035Z]

Unstable test case

@bb7133 bb7133 added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 2b55800 into pingcap:release-4.0 Jul 8, 2020
@bb7133 bb7133 mentioned this pull request Jul 23, 2020
Merged
5 tasks
@AilinKid AilinKid mentioned this pull request Sep 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@zimulala zimulala Awaiting requested review from zimulala

@tangenta tangenta Awaiting requested review from tangenta

@bb7133 bb7133 Awaiting requested review from bb7133

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rustin170506 @AilinKid @ti-srebot @bb7133 @zimulala @tangenta