charset: fix incorrect result when querying in-txn updates when new collation is enabled #18703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb7133
added
status/WIP
require-LGT3
…ollation is enabled
bb7133
force-pushed
the
bb7133/fix_idx_collation
branch
from
7f5cbc0
to
f1aba80
Compare
|
LGTM |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Jul 21, 2020
|
/run-all-tests |
|
/run-all-tests |
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@bb7133 merge failed. |
|
/run-integration-copr-test |
|
/run-check_dev |
bb7133
changed the title
gregwebs
added a commit
to gregwebs/tidb
that referenced
this pull request
Sep 1, 2020
The decoding status can be tracked by the type system. This can help prevent bugs such as the one fixed here: pingcap#18703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #18702
Problem Summary:
In TiDB, an uncommitted update within an ongoing transaction is saved in a memory buffer. When read by the ongoing transaction, the value in the memory buffer is supposed to be returned. However, for a column with new collation(when the config
new_collations_enabled_on_first_bootstrapis set to true) and the ongoing transaction is reading the uncommitted update with a unique index, the value is wrongly decoded. As a result, the uncommitted update is not included in the result and thus causes the bug.What is changed and how it works?
What's Changed and how it works:
The
DecodeIndexHandleis used to decode the handle from the index value in the memory buffer, fix it by adding support for the new collation:tidb/executor/mem_reader.go
Line 350 in 1077b04
Check List
Tests
See the charset: incorrect result when querying in-txn updates when new collation is enabled #18702
Side effects
Release note