types: fix STR_TO_DATE handling for %h, %r (#18171) (#18428) #18725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
|
@dyzsr please accept the invitation then you can push to the cherry-pick pull requests. |
qw4990
reviewed
Jul 22, 2020
qw4990
reviewed
Jul 22, 2020
types/format_test.go
Outdated
| ======= | ||
| {`12:43:24`, `%h:%i:%s`, types.FromDate(0, 0, 0, 0, 43, 24, 0)}, | ||
| {`abc`, `abc`, types.ZeroCoreTime}, | ||
| >>>>>>> cc0b6f1... types: fix STR_TO_DATE handling for %h, %r (#18171) (#18428) |
There was a problem hiding this comment.
Please resolve conflicts. @dyzsr
ti-srebot
added
status/LGT2
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/run-unit-test |
|
/merge |
|
Sorry @XuHuaiyu, you don't have permission to trigger auto merge event on this branch. |
|
@qw4990 can merge now |
I have no permission, PTAL @zz-jason @SunRunAway |
|
/merge |
|
/run-all-tests |
zz-jason
approved these changes
Jul 24, 2020
ti-srebot
added
status/LGT3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18428 to release-3.0
What problem does this PR solve?
Issue Number: close #18171
Problem Summary: Behavior of function
STR_TO_DATEis not compatible with MySQL.What is changed and how it works?
What's Changed:
How it Works:
mysqlTimeFixinspects the occurrence of '%h', '%p' and whether the hour part is 12.time12Hournow fixes the time when the hour part is 12.Tests
Side effects
No.
Release note