Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: convert lockKeys to key flag #18966

Merged
merged 3 commits into from
Aug 7, 2020
Merged

Conversation

bobotu
Copy link
Contributor

@bobotu bobotu commented Aug 4, 2020

What problem does this PR solve?

  • Convert tikvTxn.lockKeys and tikvTxn.lockedMap to KeyFlags in MemBuffer.
  • Simplify twoPhaseCommitter.initKeysAndMutations.
  • Fix some typo in memdb.go.

Check List

Tests

  • Unit test

Release note

  • Reduce large pessimistic transaction's memory usage.

@bobotu bobotu added the sig/transaction SIG:Transaction label Aug 4, 2020
@bobotu bobotu added this to the v5.0.0-alpha milestone Aug 4, 2020
@bobotu
Copy link
Contributor Author

bobotu commented Aug 4, 2020

/run-all-tests

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #18966 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #18966   +/-   ##
===========================================
  Coverage   79.4249%   79.4249%           
===========================================
  Files           546        546           
  Lines        149399     149399           
===========================================
  Hits         118660     118660           
  Misses        21234      21234           
  Partials       9505       9505           

@tiancaiamao
Copy link
Contributor

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 5, 2020
@bobotu bobotu requested a review from a team as a code owner August 6, 2020 06:37
@bobotu bobotu requested review from XuHuaiyu and removed request for a team and XuHuaiyu August 6, 2020 06:37
@bobotu
Copy link
Contributor Author

bobotu commented Aug 6, 2020

/run-all-tests

@bobotu
Copy link
Contributor Author

bobotu commented Aug 6, 2020

/rebuild

1 similar comment
@imtbkcat
Copy link

imtbkcat commented Aug 6, 2020

/rebuild

@bobotu
Copy link
Contributor Author

bobotu commented Aug 6, 2020

/run-all-tests

@bobotu
Copy link
Contributor Author

bobotu commented Aug 6, 2020

/run-common-test

@bobotu
Copy link
Contributor Author

bobotu commented Aug 6, 2020

PTAL @cfzjywxk

sessionctx/stmtctx/stmtctx.go Show resolved Hide resolved
store/tikv/txn.go Show resolved Hide resolved
@bobotu
Copy link
Contributor Author

bobotu commented Aug 6, 2020

/run-all-tests

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Aug 6, 2020

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 6, 2020
@bobotu
Copy link
Contributor Author

bobotu commented Aug 7, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 7, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@bobotu merge failed.

@bobotu
Copy link
Contributor Author

bobotu commented Aug 7, 2020

/run-unit-test

@bobotu bobotu merged commit 2d54976 into pingcap:master Aug 7, 2020
@bobotu bobotu deleted the pessimistic-lock-flags branch August 7, 2020 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/executor sig/transaction SIG:Transaction status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants