-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: convert lockKeys to key flag #18966
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #18966 +/- ##
===========================================
Coverage 79.4249% 79.4249%
===========================================
Files 546 546
Lines 149399 149399
===========================================
Hits 118660 118660
Misses 21234 21234
Partials 9505 9505 |
LGTM |
bobotu
force-pushed
the
pessimistic-lock-flags
branch
from
August 6, 2020 03:18
a770ef5
to
924886f
Compare
bobotu
force-pushed
the
pessimistic-lock-flags
branch
from
August 6, 2020 06:37
924886f
to
b376219
Compare
bobotu
requested review from
XuHuaiyu
and removed request for
a team and
XuHuaiyu
August 6, 2020 06:37
/run-all-tests |
/rebuild |
1 similar comment
/rebuild |
/run-all-tests |
/run-common-test |
PTAL @cfzjywxk |
cfzjywxk
reviewed
Aug 6, 2020
/run-all-tests |
LGTM |
ti-srebot
approved these changes
Aug 6, 2020
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Aug 7, 2020
/run-all-tests |
@bobotu merge failed. |
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/executor
sig/transaction
SIG:Transaction
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
tikvTxn.lockKeys
andtikvTxn.lockedMap
toKeyFlags
inMemBuffer
.twoPhaseCommitter.initKeysAndMutations
.memdb.go
.Check List
Tests
Release note