Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ranger: support using nulleq conditions to calculate index ranges #19035

Merged
merged 9 commits into from
Aug 19, 2020

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Aug 6, 2020

What problem does this PR solve?

Issue Number: close #18980

Problem Summary: ranger: support using nulleq conditions to calculate index ranges

What is changed and how it works?

Support using nulleq conditions to calculate index ranges.
Please see #18980 for more details.

Check List

Tests

  • Unit test

Release note

  • ranger: support using nulleq conditions to calculate index ranges

@qw4990 qw4990 requested review from eurekaka and winoros August 6, 2020 07:16
@qw4990 qw4990 requested review from a team as code owners August 6, 2020 07:16
@qw4990 qw4990 requested review from SunRunAway and removed request for a team August 6, 2020 07:16
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 6, 2020

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 6, 2020

/run-unit-test

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #19035 into master will decrease coverage by 0.0878%.
The diff coverage is 100.0000%.

@@               Coverage Diff                @@
##             master     #19035        +/-   ##
================================================
- Coverage   79.4691%   79.3812%   -0.0879%     
================================================
  Files           546        546                
  Lines        148172     147943       -229     
================================================
- Hits         117751     117439       -312     
- Misses        20954      21014        +60     
- Partials       9467       9490        +23     

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 6, 2020
@github-actions github-actions bot added the sig/planner SIG: Planner label Aug 11, 2020
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 14, 2020

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 18, 2020

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 18, 2020

/run-all-tests

Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 18, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 18, 2020
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 18, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 18, 2020
@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 18732
  • 18846
  • 19237
  • 19237
  • 19237
  • 19202
  • 18970

@eurekaka
Copy link
Contributor

@qw4990 please fix CI.

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@qw4990 merge failed.

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 19, 2020

/run-all-tests

1 similar comment
@qw4990
Copy link
Contributor Author

qw4990 commented Aug 19, 2020

/run-all-tests

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 19, 2020

/run-common-test
/run-sqllogic-test-1
/run-sqllogic-test-2
/run-unit-test

@qw4990
Copy link
Contributor Author

qw4990 commented Aug 19, 2020

/run-all-tests

@qw4990 qw4990 merged commit cd8654f into pingcap:master Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nulleq operator cannot be used to calculate ranges
5 participants