*: fix a bug causes indexed virtual generated column return wrong value and refine admin check table (#18408) #19062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the CI |
…rtual_index_40hotfix
wjhuang2016
force-pushed
the
virtual_index_40hotfix
branch
from
3c47651
to
31ea1b5
Compare
ti-srebot
approved these changes
Aug 11, 2020
|
Any conflicts? |
|
/merge |
ti-srebot
added
the
status/can-merge
Cherry-pick from a middle commit. Because the previous commit contains clustered indexes stuffs. |
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17989
Problem Summary:
column substitutionto decode a multi-level virtual generated column, which is buggy.admin check tableuses tableReader, and tableReader can output rows with a virtual generated column already, we don't need to compute it again. Besides, the previous implementation also suffered the above problem.I’m
What is changed and how it works?
ColumnInfos2ColumnsAndNames.genExprsincheckIndexValue.compareData, don't compute the virtual generated column again.rewriteAstExpr, so that we can userewritein package expression.buildPhysicalIndexLookUpReader, make it simple.table/tables/gen_expr_test.go → util/generatedexpr/gen_expr_test.go. to avoid circular reference.What's Changed:
How it Works:
Related changes
Check List
Tests
Side effects
Release note