Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: cherry-pick #17964 and update pd to v4.0.4 #19105

Merged
merged 4 commits into from
Aug 20, 2020

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Cherrypick #17964 and update pd to v4.0.4.

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No Release note.

Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

coocood and others added 2 commits August 18, 2020 14:47
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
@bb7133
Copy link
Member

bb7133 commented Aug 20, 2020

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 20, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 20, 2020
@bb7133
Copy link
Member

bb7133 commented Aug 20, 2020

/merge

@ti-srebot
Copy link
Contributor

Sorry @bb7133, you don't have permission to trigger auto merge event on this branch.
The version releasement is in progress.

@jebter
Copy link

jebter commented Aug 20, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 20, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@overvenus merge failed.

@jebter
Copy link

jebter commented Aug 20, 2020

/run-integration-ddl-test

@jebter jebter merged commit c5b7658 into pingcap:release-4.0 Aug 20, 2020
@overvenus overvenus deleted the release-4.0-br-api branch August 20, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config component/executor sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants