*: add rollbacking logic for column type change #19531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AilinKid
added
require-LGT3
blacktear23
reviewed
Aug 31, 2020
blacktear23
reviewed
Aug 31, 2020
crazycs520
reviewed
Sep 1, 2020
crazycs520
reviewed
Sep 1, 2020
wjhuang2016
requested changes
Sep 2, 2020
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
Signed-off-by: AilinKid <314806019@qq.com>
Signed-off-by: AilinKid <314806019@qq.com>
Signed-off-by: AilinKid <314806019@qq.com>
Signed-off-by: AilinKid <314806019@qq.com>
Signed-off-by: AilinKid <314806019@qq.com>
AilinKid
force-pushed
the
refine_rollback_col_type_change
branch
from
13e48f3
to
44347e6
Compare
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
/build |
Signed-off-by: AilinKid <314806019@qq.com>
|
/run-unit-test |
|
/run-common-test |
|
/merge |
|
/run-all-tests |
|
@AilinKid merge failed. |
|
/run-all-tests |
|
/run-common-test |
|
/run-integration-common-test |
|
/run-tics-test |
|
/run-all-tests |
|
/run-integration-common-test |
|
/run-unit-test |
3 similar comments
|
/run-unit-test |
|
/run-unit-test |
|
/run-unit-test |
|
/merge |
|
/run-all-tests |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
@AilinKid merge failed. |
|
/run-unit-test |
|
/merge |
|
/run-all-tests |
|
@AilinKid merge failed. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Since #19059 has supported the column type change between integers.
This PR is to support rollbacking modify column job at four states including
StateNone,StateDeleteOnly,StateWriteOnly,StateWriteReorganization.Close issue: #19119
What is changed and how it works?
How it Works:
The column type change is implemented by appending an additional column and indexes into meta in the middle state. When reorganization is finished in
StateWriteReorganizationstate, TiDB will substitute the old ones with these additional columns and indexes. These additional columns and indexes are named aschangingColandchangingIndexesin our proposal.Because of this, rolling back modify column jobs in the middle state is much easier than other DDL jobs. At any one of the middle states, we can directly remove those
changingColandchangingIndexfrom meta. Next, we should restore some flag in the field type of the old column likePreventNullInsertFlag. Last, don't forget to add the index table into the delete range table.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Release note